| Both sides previous revision
Previous revision
Next revision
|
Previous revision
|
dev:thorn_notation_review [2009/11/25 09:03]
michael |
dev:thorn_notation_review [2009/11/30 18:45]
janifr |
| **BUG** I'm in select mode (arrow tool) and the duration monobar is in rest mode. I want to insert a note. I click the note/rest switcher button to switch the palette, expecting it to switch the palette to notes and also switch the tool to the pencil, but this does not happen. I've been trying to ignore and get used to this fact, but it keeps irritating me, and if I keep being irritated by what I expect to happen not happening, I think it means the interface is wrong, and it should be made to behave as I keep expecting intuitively. | **BUG** I'm in select mode (arrow tool) and the duration monobar is in rest mode. I want to insert a note. I click the note/rest switcher button to switch the palette, expecting it to switch the palette to notes and also switch the tool to the pencil, but this does not happen. I've been trying to ignore and get used to this fact, but it keeps irritating me, and if I keep being irritated by what I expect to happen not happening, I think it means the interface is wrong, and it should be made to behave as I keep expecting intuitively. |
| |
| **BUG** The status bar is still completely screwy. The most important thing missing for me is the little thing that shows what pitch you're hovering over. I miss that. | **BUG** The status bar is still completely screwy. The most important thing missing for me is the little thing that shows what pitch you're hovering over. I miss that. I miss that too. -Jani |
| |
| **BUG** Add a key change, try to select the key signature, and it disappears! WTF? It seems to continue to exist and to have an effect, but it's quite invisible. Strangely enough, in a basic one bar test segment, right clicking the whole rest and "make invisible" makes the key signature reappear briefly. Also, when triple-clicking to select the whole staff, the key signature goes blue briefly before disappearing, so it's not something completely stupid like trying to paint it in NPF with the selected color goes wrong and draws it transparent. Although that may yet turn out to be the key. (Transparency brought on by NPF, I mean.) | **BUG** Add a key change, try to select the key signature, and it disappears! WTF? It seems to continue to exist and to have an effect, but it's quite invisible. Strangely enough, in a basic one bar test segment, right clicking the whole rest and "make invisible" makes the key signature reappear briefly. Also, when triple-clicking to select the whole staff, the key signature goes blue briefly before disappearing, so it's not something completely stupid like trying to paint it in NPF with the selected color goes wrong and draws it transparent. Although that may yet turn out to be the key. (Transparency brought on by NPF, I mean.) |
| ==== Select From Start / To End ==== | ==== Select From Start / To End ==== |
| Works, with caveats. | Works, with caveats. |
| **BUG** It is generally possible to wind up with staff 1 active (gauged by subsequent behavior, and the track header box) but the edit cursor is spanning staff 2 incorrectly. This is probably some kind of broader refresh bug or something. Just noting inline for now. | (Ignore the caveats for Thorn.) |
| ==== Select Whole Staff ==== | ==== Select Whole Staff ==== |
| |
| ==== Filter Selection ==== | ==== Filter Selection ==== |
| Event filter layout looks good, and I tested a handful of different "pick this but not that" scenarios with consistent results. (It reminds me how this thing has never been as useful as it ought to have been, and needs a rewrite one day.) | Event filter layout looks good, and I tested a handful of different "pick this but not that" scenarios with consistent results. (It reminds me how this thing has never been as useful as it ought to have been, and needs a rewrite one day.) |
| **REMINDER** Now that the event list editor no longer allows multi-event selections (because there was no realistic way to edit or otherwise act upon multiple events, except perhaps to delete them, and that didn't work either, so I made it a single select), the event filter icon William made us put there is now totally useless, and should be removed. | |
| |
| ==== Preferences ==== | ==== Preferences ==== |
| ===== View ===== | ===== View ===== |
| ==== Note Font ==== | ==== Note Font ==== |
| Some of the font mappings have problems here. Particular Inkpen. I don't think I care much, and now that we don't do printing in house, none of this matters all that much anyway. (If LilyPond can use different fonts, that's something we should support. Especially if it can use that stupid jazz fakebook font some people are so fond of, which is the main complaint we've gotten over the years.) | Some of the font mappings have problems here. Particularly Inkpen. I don't think I care much, and now that we don't do printing in house, none of this matters all that much anyway. (If LilyPond can use different fonts, that's something we should support. Especially if it can use that stupid jazz fakebook font some people are so fond of, which is the main complaint we've gotten over the years.) |
| |
| ==== Size ==== | ==== Size ==== |
| ==== Add Tempo Change ==== | ==== Add Tempo Change ==== |
| Tempo dialog looks good generally. Tap to set tempo works. | Tempo dialog looks good generally. Tap to set tempo works. |
| **BROKEN HELP BUTTON** | |
| |
| Inserting a tempo from the dialog doesn't seem to behave predictably, and neither do the tempo ruler functions. This needs re-examination in a cleaner test environment than I have now. | Inserting a tempo from the dialog doesn't seem to behave predictably, and neither do the tempo ruler functions. This needs re-examination in a cleaner test environment than I have now. |
| |
| ==== Add Time Signature Change ==== | ==== Add Time Signature Change ==== |
| **BROKEN HELP BUTTON** | |
| Too much space between numerator and denominator. Took a whack at that one, and any improvement is so subtle I'd have to compare before and after screenshots to see if I shaved any pixels. Stubbornly resistant to change. Something in numBox and denomBox has a large sizeHint() apparently. Even changing to QSizePolicy::Maximum had no effect on the vertical spacing, although it did wreck the horizontal spacing nicely. | Too much space between numerator and denominator. Took a whack at that one, and any improvement is so subtle I'd have to compare before and after screenshots to see if I shaved any pixels. Stubbornly resistant to change. Something in numBox and denomBox has a large sizeHint() apparently. Even changing to QSizePolicy::Maximum had no effect on the vertical spacing, although it did wreck the horizontal spacing nicely. |
| |
| OK. | OK. |
| |
| **Observation** For the sake of sanity, logic, and reason, it may be a good idea to disable all property and control rulers in multi-staff/multi-segment views. I have not looked at Classic during this test, but I remember looking at Classic while considering this point fairly recently, and I recall that Classic made a complete mess of this. It's a mind bending problem trying to decide how it should behave, and I think disabling it is a fair option to consider. Want to use the rulers? Do it segment by segment. Worth discussing! | **Need to implement option 4 in off-list discussion.** |
| | FIXME One property/pitch/controller n ruler per view. Ruler tracks active segment and updates its contents to reflect |
| === Set Event Velocities === | === Set Event Velocities === |
| Works swimmingly now that I've fixed the dialog. | Works swimmingly now that I've fixed the dialog. |
| ==== Symbols ==== | ==== Symbols ==== |
| ==== Text ==== | ==== Text ==== |
| **BUG** No Help link | |
| |
| I reviewed the behavior not long back and fixed the text background, resizing problem,and so on. I have not done a fresh review, but at a glance it seems to be in the state I left it in, and well-behaved enough for release. | I reviewed the behavior not long back and fixed the text background, resizing problem,and so on. I have not done a fresh review, but at a glance it seems to be in the state I left it in, and well-behaved enough for release. |
| |
| |
| ==== Grace Insert Mode ==== | ==== Grace Insert Mode ==== |
| Seems to be working a well as always. There are still problems with ledger lines and grace notes. The note heads are scaled down, and so are the lines, so if you have a grace with ledger lines adjacent to a full sized note with ledger lines, they don't sync up at all. It might be worth taking a quick look at fixing this one before February, because it has irritated me for a long time, and it might not actually be that difficult to solve. I'll try to look into this shortly. But anyway, definitely working well enough to release with as far as my experiments have shown (and a vast, VAST improvement over the old grace note tool that was utterly worthless). | Seems to be working as well as always. **FIXED** the stupid grace note scaling problem (more or less, I hope) |
| |
| |
| (Note, I did this in bottom to top order originally, and I've grown bored with rearranging it back into top to bottom order.) | (Note, I did this in bottom to top order originally, and I've grown bored with rearranging it back into top to bottom order.) |
| ==== Next / Previous Segment ==== | ==== Next / Previous Segment ==== |
| Not working, or has no meaning in the current testing context. **REVIEW** | Seems to work well enough, with some caveats I'm going to ignore until Abraham Darby unless they prove immensely serious |
| |
| ==== Next Staff Up / Down ==== | ==== Next Staff Up / Down ==== |
| |
| ==== Clear Loop ==== | ==== Clear Loop ==== |
| **BUG** This should use action states. If there is no loop to clear, this should not be enabled. | |
| |
| If a loop is set manually, this does work. | If a loop is set manually, this does work. |
| |
| ==== Set Loop to Selection ==== | ==== Set Loop to Selection ==== |
| Obeys "have selection" action state. | Obeys "have selection" action state. |
| |
| **BUG** Does not function! (Missing slot?) **NOTE** I am testing in a multi-staff view | |
| |
| ==== Cursor Back / Forward and Select ==== | ==== Cursor Back / Forward and Select ==== |
| **BUG** Does not function! (Missing slot?) | |
| |
| Dubious icons. I'm not sure about these, but I think I like them better than I did the last time I looked at them, so maybe we should leave well enough alone there. (Or remove this feature if it won't be made to work again.) | Dubious icons. I'm not sure about these, but I think I like them better than I did the last time I looked at them, so maybe we should leave well enough alone there. (Or remove this feature if it won't be made to work again.) |
| |
| Choosing chords and inserting them into notation works generally. | Choosing chords and inserting them into notation works generally. |
| |
| **BUG** Something is wrong with the highlight colors. The highlighted fretboard has a different background from all the other highlights. May be a style problem. | **BUG** Something is wrong with the highlight colors. The highlighted fretboard has a different background from all the other highlights. May be a style problem. [Fsck it. Not even moving this to the Abraham Darby page.] |
| |
| ===== Editing Chords ===== | ===== Editing Chords ===== |
| Seems to work and look rather better than it used to. | Seems to work and look rather better than it used to. |
| |
| **BUG** From fret 5 onward, the little blue hover cursor does not show up, and it isn't apparent you can click to make a dot appear. | **BUG** From fret 5 onward, the little blue hover cursor does not show up, and it isn't apparent you can click to make a dot appear. [Fsck it. Not even moving this to the Abraham Darby page.] |
| |
| ===== Deleting Chords ===== | ===== Deleting Chords ===== |
| Not very apparent which ones can be deleted and which ones can't, but the "Delete" button does cycle enabled states appropriately, and this does seem to work generally. General improvement might be indicated long after more pressing matters are dealt with. | Not very apparent which ones can be deleted and which ones can't, but the "Delete" button does cycle enabled states appropriately, and this does seem to work generally. General improvement might be indicated long after more pressing matters are dealt with. |
| |
